Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support foreign tables in MX #5461
Support foreign tables in MX #5461
Changes from all commits
eef9d76
d986697
82cd83a
30f372d
2390e71
0e283e2
1be73ff
7950c8c
e8009e4
d94a70a
7a1259d
5141a61
e77c0fa
9aa2ef8
eda8d47
4ecd727
94ec5fc
c12f53a
392031e
6ea1fc8
e484bad
3d1290e
ee41210
615bbea
4d3eda3
ae5f118
43256e1
63e3abc
a10fa7c
8a87195
d82dd14
15feb7a
ce4427c
4432541
0e963c5
dd44b11
26d1edf
87d9577
e46e2df
775fe2c
5c63575
8acc644
8e01ad9
43286ab
df1bf49
b35413f
b055f77
b592589
e6a71db
fae934d
cfd3533
65dfa67
44747be
11c0a3a
1f3d68c
6deef85
68b3610
399d6ca
d7f7954
e524408
afcd212
20d8b04
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? Maybe mention in the comment:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor: I think it'd be easier to read
ALTER %s TABLE ", isForeignTable ? "FOREIGN" : "
. Is that breaking other tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no that wouldn't break anything but it just annoys me with two space characters together, between
ALTER
andTABLE
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One another question I have is regarding this: https://www.postgresql.org/docs/14/sql-importforeignschema.html
How would
IMPORT FOREIGN SCHEMA
work with Citus whenSET citus.use_citus_managed_tables TO ON;
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping on this, it seems like a common pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we decided that we'll do this later on with a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting for future reference. Our reason to remove these here has two aspects:
(a) we do not find dependency between the server and the extension as we expect all extensions to be already distributed and exists on the workers
(b) The server has already been created and exists on the workers