Remove citus.shard_placement_policy #5690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5690 +/- ##
==========================================
+ Coverage 92.60% 92.79% +0.19%
==========================================
Files 219 219
Lines 46454 46353 -101
==========================================
- Hits 43017 43015 -2
+ Misses 3437 3338 -99 |
onurctirtir
approved these changes
Feb 7, 2022
| @@ -1629,22 +1622,6 @@ RegisterCitusConfigVariables(void) | |||
| GUC_STANDARD, | |||
| NULL, NULL, NULL); | |||
|
|
|||
| DefineCustomEnumVariable( | |||
| "citus.shard_placement_policy", | |||
There was a problem hiding this comment.
quite interesting that we didn't have any files testing this guc (i.e.: set citus.shard_placement_policy to foo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Removes citus.shard_placement_policy
The citus.shard_placement_policy GUC is only used in master_create_empty_shard, which exists primarily as rudimentary shard creation mechanism for range/append-distributed tables. After this PR, master_create_empty_shard uses round-robin placement when replication factor > 1, same as create_distributed_table does for hash-distributed tables.
The removed code was not covered by any tests.