Handle identity columns properly in the router planner #6802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6802 +/- ##
==========================================
+ Coverage 92.86% 93.16% +0.29%
==========================================
Files 262 262
Lines 56375 56377 +2
==========================================
+ Hits 52354 52522 +168
+ Misses 4021 3855 -166 |
marcocitus
reviewed
Mar 29, 2023
| /* check if the node contains an identity column */ | ||
| if (IsA(node, NextValueExpr)) | ||
| { | ||
| return true; |
There was a problem hiding this comment.
makes sense, but could use a test
marcocitus
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Fixes a bug with insert..select queries with identity columns
Fixes #6798