Fix create schema authorization bug #7015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcocitus
reviewed
Jun 20, 2023
| SET citus.enable_schema_based_sharding TO ON; | ||
| CREATE ROLE a; | ||
| CREATE SCHEMA AUTHORIZATION a; | ||
| SET citus.enable_schema_based_sharding TO OFF; |
There was a problem hiding this comment.
would be nice to add a check to confirm that the schema is actually distributed
also, should drop the role at the end
aykut-bozkurt
force-pushed
the
fix-schema-authorization
branch
from
3f2ae4f
to
59bc689
Compare
aykut-bozkurt
force-pushed
the
fix-schema-authorization
branch
from
59bc689
to
316f095
Compare
marcocitus
approved these changes
Jun 20, 2023
Codecov Report
@@ Coverage Diff @@
## main #7015 +/- ##
==========================================
- Coverage 93.35% 93.33% -0.03%
==========================================
Files 273 273
Lines 58475 58479 +4
==========================================
- Hits 54592 54581 -11
- Misses 3883 3898 +15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug related to
CREATE SCHEMA AUTHORIZATIONfor single shard tables. We should properly fetch schema name from role specification if schema name is not given.