get rid of {Push/Pop}OverrideSearchPath #7145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhjwpku
force-pushed
the
get_rid_of_override_search_path
branch
2 times, most recently
from
056b25e
to
8b42672
Compare
zhjwpku
changed the title
zhjwpku
force-pushed
the
get_rid_of_override_search_path
branch
3 times, most recently
from
c37c8f9
to
4ba329d
Compare
marcocitus
approved these changes
Sep 5, 2023
zhjwpku
force-pushed
the
get_rid_of_override_search_path
branch
from
4ba329d
to
d62f124
Compare
Codecov Report
@@ Coverage Diff @@
## main #7145 +/- ##
==========================================
- Coverage 93.22% 93.21% -0.01%
==========================================
Files 274 274
Lines 59327 59235 -92
==========================================
- Hits 55307 55216 -91
+ Misses 4020 4019 -1 |
marcocitus
force-pushed
the
get_rid_of_override_search_path
branch
from
d62f124
to
a0619c7
Compare
PushOverrideSearchPath suffers from a vulnerability issue reported by CVE-2023-2454. Postgres fix this by replacing it with set_config_option, see [1]. It is recommended that out-of-tree code should also update such code though the "override" mechanism remains for compatibility. The postgres master branch(i.e. PG 17) recently removed PushOverrideSearchPath() and PopOverrideSearchPath(), see [2]. So this should also ease the process when citus decide to support Postgres v17. This patch also contains some trivial typo fix. [1]: postgres commit: 681d9e4621aac0a9c71364b6f54f00f6d8c4337f [2]: postgres commit: 7c5c4e1c0396b0617a6f9b659dd7375fb0bfb9dc Signed-off-by: Zhao Junwang <zhjwpku@gmail.com>
marcocitus
force-pushed
the
get_rid_of_override_search_path
branch
from
a0619c7
to
c98256e
Compare
francisjodi
pushed a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PushOverrideSearchPath suffers from a vulnerability issue reported by
CVE-2023-2454. Postgres fix this by replacing it with set_config_option, see [1].
It is recommended that out-of-tree code should also update such code though
the "override" mechanism remains for compatibility.
The postgres master branch(i.e. PG 17) recently removed
PushOverrideSearchPath() and PopOverrideSearchPath(), see [2]. So this should
also ease the process when citus decide to support Postgres v17.
This patch also contains some trivial typo fix.
[1]: postgres commit: 681d9e4621aac0a9c71364b6f54f00f6d8c4337f
[2]: postgres commit: 7c5c4e1c0396b0617a6f9b659dd7375fb0bfb9dc