avoid rebuilding MetadataCache for each placement insertion #7163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhjwpku
force-pushed
the
reduce_metadata_cache_invalidation_count
branch
from
d5c192f
to
723292a
Compare
Codecov Report
@@ Coverage Diff @@
## main #7163 +/- ##
==========================================
- Coverage 93.21% 93.21% -0.01%
==========================================
Files 274 274
Lines 59229 59233 +4
==========================================
+ Hits 55209 55212 +3
- Misses 4020 4021 +1 |
for reference table and distributed table without colocation field, each time we insert a shard placement, it invalidate the metadata cache with the relation oid, and build it by a following `LoadShardPlacement`, this was partly fixed by citusdata#6722 for CreateColocatedShards, problem still exists for other cases, this patch fix them. Signed-off-by: Zhao Junwang <zhjwpku@gmail.com>
marcocitus
force-pushed
the
reduce_metadata_cache_invalidation_count
branch
from
723292a
to
87c341e
Compare
marcocitus
approved these changes
Sep 1, 2023
|
The CI failure comes from yum downloading error, maybe reschedule the workflow? |
|
Thanks, a very useful improvement and the code flows a bit more nicely. |
francisjodi
pushed a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for reference table and distributed table without colocation field,
each time we insert a shard placement, it invalidate the metadata cache with the
relation oid, and build it by a following
LoadShardPlacement, this was partlyfixed by #6722 for CreateColocatedShards, problem still exists for other cases,
this patch fix them all.