Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional alter database propagation support #7253

Merged
merged 316 commits into from
Dec 26, 2023

Conversation

gurkanindibay
Copy link
Contributor

@gurkanindibay gurkanindibay commented Oct 12, 2023

DESCRIPTION: Adds database connection limit, rename and set tablespace propagation
In this PR, below statement propagations are added

alter database <database_name> with allow_connections = <boolean_value>;
alter database <database_name> rename to <database_name2>;
alter database <database_name> set TABLESPACE <table_space_name>

@gurkanindibay gurkanindibay changed the title Adds connection limit Adds database connection limit and rename statements Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #7253 (ce32be6) into main (b877d60) will decrease coverage by 5.35%.
The diff coverage is 91.66%.

❗ Current head ce32be6 differs from pull request most recent head 0975f7b. Consider uploading reports for the commit 0975f7b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7253      +/-   ##
==========================================
- Coverage   89.60%   84.26%   -5.35%     
==========================================
  Files         278      350      +72     
  Lines       60099    62696    +2597     
  Branches     7487     8126     +639     
==========================================
- Hits        53853    52830    -1023     
- Misses       4100     7629    +3529     
- Partials     2146     2237      +91     

@gurkanindibay gurkanindibay changed the title Adds database connection limit and rename statements Adds database connection limit and rename statement propagation Oct 12, 2023
@gurkanindibay gurkanindibay marked this pull request as ready for review October 12, 2023 12:46
src/backend/distributed/commands/database.c Show resolved Hide resolved
src/backend/distributed/commands/database.c Outdated Show resolved Hide resolved
src/backend/distributed/commands/database.c Show resolved Hide resolved
src/backend/distributed/commands/database.c Outdated Show resolved Hide resolved
src/backend/distributed/commands/database.c Outdated Show resolved Hide resolved
src/backend/distributed/commands/database.c Outdated Show resolved Hide resolved
@gurkanindibay gurkanindibay changed the title Adds database connection limit and rename statement propagation Adds additional alter database propagation support Oct 13, 2023
@gurkanindibay
Copy link
Contributor Author

@onurctirtir waiting for your last review FYI

src/backend/distributed/commands/database.c Outdated Show resolved Hide resolved
src/backend/distributed/commands/database.c Show resolved Hide resolved
src/backend/distributed/commands/database.c Show resolved Hide resolved
src/backend/distributed/deparser/deparse_database_stmts.c Outdated Show resolved Hide resolved
src/backend/distributed/deparser/deparse_database_stmts.c Outdated Show resolved Hide resolved
src/backend/distributed/commands/database.c Outdated Show resolved Hide resolved
src/backend/distributed/commands/database.c Outdated Show resolved Hide resolved
src/backend/distributed/deparser/deparse_database_stmts.c Outdated Show resolved Hide resolved
src/backend/distributed/commands/database.c Outdated Show resolved Hide resolved
@gurkanindibay
Copy link
Contributor Author

I'm checking for Codecov results and see that even the main execution blocks seem uncovered. I think they are false positives

@onurctirtir onurctirtir mentioned this pull request Nov 29, 2023
57 tasks
Copy link
Member

@onurctirtir onurctirtir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, let me quickly perform some manual testing while you're addressing those last a few comments.

src/backend/distributed/deparser/deparse_database_stmts.c Outdated Show resolved Hide resolved
src/backend/distributed/commands/database.c Outdated Show resolved Hide resolved
src/test/regress/sql/alter_database_propagation.sql Outdated Show resolved Hide resolved
src/test/regress/sql/alter_database_propagation.sql Outdated Show resolved Hide resolved
@onurctirtir onurctirtir removed the request for review from halilozanakgul December 26, 2023 11:41
@gurkanindibay gurkanindibay merged commit 181b8ab into main Dec 26, 2023
157 checks passed
@gurkanindibay gurkanindibay deleted the alter_database_additional_options branch December 26, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants