Enforce using werkzeug 2.3.7 for failure tests and update Postgres versions to latest minors #7491
Conversation
onurctirtir
requested review from
thanodnl,
halilozanakgul,
mgencel and
aykut-bozkurt
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7491 +/- ##
==========================================
- Coverage 89.60% 88.83% -0.78%
==========================================
Files 282 282
Lines 60322 60321 -1
Branches 7512 7510 -2
==========================================
- Hits 54052 53586 -466
- Misses 4116 4553 +437
- Partials 2154 2182 +28 |
Is this error actually causing problems (e.g. failing tests)? Or is it simply some annoying output that is being displayed? I think to limit the amount of security warnings we get it would be nice not to pin libraries to some old version if not strictly needed. |
The error causes regression test suit to fail indeed. |
|
Hmm okay, it seems Pipfile.lock got outdated with our the-process images then. Because Pipfile.lock is already listing 3.0.2 for werkzeug while failtester its requirements.txt has 2.3.7: https://github.com/citusdata/the-process/blob/master/circleci/images/failtester/files/etc/requirements.txt#L54 I think going for 2.3.7 makes more sense then. Also there should be a matching PR to update the images in the-process and this PR should start using those images to check that everything works fine. |
onurctirtir
changed the title
onurctirtir
changed the title
…latest minors to fix builds (#155) Bake new images for citusdata/citus#7491. We also update Postgres minor versions to resolve build issues that happens due to some portion of images assuming that we're always using latest minors --regardless of what circleci/images/PG_VERSIONS says, see https://github.com/citusdata/the-process/actions/runs/7928205849/job/21646015823#step:4:1061.
.github/workflows/build_and_test.yml
Outdated
| pg15_version: '{ "major": "15", "full": "15.5" }' | ||
| pg16_version: '{ "major": "16", "full": "16.1" }' | ||
| upgrade_pg_versions: "14.10-15.5-16.1" | ||
| image_suffix: "-dev-4f49b4a" |
There was a problem hiding this comment.
Reminder that this needs to be replaced with a non-dev image before merging once citusdata/the-process#155 has passed through CI
…rsions to latest minors (citusdata#7491) Let's use version 2.3.7 to fix the following error as we do in docker images created in https://github.com/citusdata/the-process/ repo. ``` ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/home/onurctirtir/.local/share/virtualenvs/regress-ffZKpSmO/lib/python3.9/site-packages/werkzeug/urls.py) ``` And changing werkzeug version required rebuilding Pipfile.lock file in src/test/regress. Before updating this Pipfile.lock file, we want to make sure that versions specified there don't break any tests. And to ensure that this is the case, citusdata/the-process#155 synchronizes requirements.txt file based on new Pipfile.lock and hence this PR updates test image suffix accordingly. Also, while updating citusdata/the-process#155, I also had to update Postgres versions to latest minors to make image builds passing again and updating Postgres versions in images requires updating Postgres versions in this repo too. While doing that, we also update Postgres version used in devcontainer too. (cherry picked from commit 74b55d0)
…rsions to latest minors (citusdata#7491) Let's use version 2.3.7 to fix the following error as we do in docker images created in https://github.com/citusdata/the-process/ repo. ``` ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/home/onurctirtir/.local/share/virtualenvs/regress-ffZKpSmO/lib/python3.9/site-packages/werkzeug/urls.py) ``` And changing werkzeug version required rebuilding Pipfile.lock file in src/test/regress. Before updating this Pipfile.lock file, we want to make sure that versions specified there don't break any tests. And to ensure that this is the case, citusdata/the-process#155 synchronizes requirements.txt file based on new Pipfile.lock and hence this PR updates test image suffix accordingly. Also, while updating citusdata/the-process#155, I also had to update Postgres versions to latest minors to make image builds passing again and updating Postgres versions in images requires updating Postgres versions in this repo too. While doing that, we also update Postgres version used in devcontainer too. (cherry picked from commit 74b55d0)
Let's use version 2.3.7 to fix the following error as we do in docker images created in https://github.com/citusdata/the-process/ repo.
And changing werkzeug version required rebuilding Pipfile.lock file in src/test/regress. Before updating this Pipfile.lock file, we want to make sure that versions specified there don't break any tests. And to ensure that this is the case, citusdata/the-process#155 synchronizes requirements.txt file based on new Pipfile.lock and hence this PR updates test image suffix accordingly.
Also, while updating citusdata/the-process#155, I also had to update Postgres versions to latest minors to make image builds passing again and updating Postgres versions in images requires updating Postgres versions in this repo too. While doing that, we also update Postgres version used in devcontainer too.