Reduce function calls to var's during requested column computation #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should change function's comment which says; "This function is unchanged from mongo_fdw." It is not related with this change but here we have nested loop over columns of the table. It could be bottleneck when column count is high. We can remove duplicates with one loop and having a bool array or set to mark already added columns. It is up to you to decide if it is worth to effort. |
|
I am not sure but is it possible to test new behavior? |
|
Added user reported issue as test case |
mtuncer
force-pushed
the
fix_95_non_var_target_list
branch
from
f1f089c
to
3a192ff
Compare
|
Looks good 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgresql does not reduce some function calls in target list when used in
union allqueries. This change usespull_var_clause()to detect Var's used in target list when detecting which columns should be returned for the query on cstore table.Fixes #107 and #95