Force preloading of extension during tests

Exercised an arcane bug wherein we'd begin a PL/pgSQL trigger without
pg_shard loaded, load it partway through, and crash because we have a
PL/pgSQL plugin that expects to be called during function entry and
exit being called only on exit.

Makefile

@@ -34,7 +34,8 @@ REGRESS = init connection distribution_metadata extend_ddl_commands \
 
 # The launcher regression flag lets us specify a special wrapper to handle
 # testing rather than psql directly. Our wrapper swaps in a known worker list.
-REGRESS_OPTS = --launcher=./launcher.sh
+# We also want pg_shard preloaded for all the tests.
+REGRESS_OPTS = --launcher=./launcher.sh --load-extension=pg_shard
 
 EXTRA_CLEAN += ${REGRESS_PREP}
 

expected/init.out

@@ -1,7 +1,6 @@
 -- ===================================================================
 -- create extension
 -- ===================================================================
-CREATE EXTENSION pg_shard;
 -- create fake fdw for use in tests
 CREATE FUNCTION fake_fdw_handler()
 RETURNS fdw_handler

sql/init.sql

@@ -2,8 +2,6 @@
 -- create extension
 -- ===================================================================
 
-CREATE EXTENSION pg_shard;
-
 -- create fake fdw for use in tests
 CREATE FUNCTION fake_fdw_handler()
 RETURNS fdw_handler