Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis and Coveralls support #40

Merged
merged 5 commits into from Dec 29, 2014
Merged

Travis and Coveralls support #40

merged 5 commits into from Dec 29, 2014

Conversation

jasonmp85
Copy link
Collaborator

Builds pg_shard against PostgreSQL 9.4 in Travis and uploads coverage information to Coveralls. Certain tests had problems that were exposed in the Travis environment, which have been corrected.

Additionally, the scripts in the Travis gist have been modified to build a cluster directly owned by the Travis user. This keeps us from needing to run a bunch of chmod/chown commands before tests.

Resolves #24.

See citusdata/cstore_fdw@b95f6d4, citusdata/cstore_fdw@0a988d6, and
citusdata/cstore_fdw@f3a56bb for more details. Will add badge once this
is confirmed working.
Missed some places that'll bite us with non-standard ports.
Turns out passing strcmp to qsort isn't possible. Added a wrapper.
The latter _should_ resolve to localhost and was being used as an easy
synonym for it, but this hack isn't working in Travis. Switched to the
IP address instead, which I didn't think would work but does.
These should probably always show the master status, but as we won't
merge these changes to master anytime soon I'm just using the generic
project badges for each service.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ab075f3 on feature-travis_integ-#24 into * on develop*.

@jasonmp85
Copy link
Collaborator Author

Assigning to @sumedhpathak for review.

[![Build Status](https://img.shields.io/travis/citusdata/pg_shard.svg)][status]
[![Coverage](https://img.shields.io/coveralls/citusdata/pg_shard.svg)][coverage]
[![Release](https://img.shields.io/github/release/citusdata/pg_shard.svg)][release]
[![License](https://img.shields.io/:license-LGPLv3-blue.svg)][license]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license link seems broken? When I view the file and click on that link, takes me to a 404 page.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because this branch has a # in the name. Looks like GitHub is not escaping that character in the link it produces, resulting in the path of the URL ending there and everything after the # being interpreted as an anchor name.

@jasonmp85
Copy link
Collaborator Author

Got a :shipit: from @sumedhpathak over GChat. Merging.

jasonmp85 added a commit that referenced this pull request Dec 29, 2014
@jasonmp85 jasonmp85 merged commit 46bcf2c into develop Dec 29, 2014
@jasonmp85 jasonmp85 deleted the feature-travis_integ-#24 branch December 29, 2014 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Travis CI and Coveralls
3 participants