Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to sync metadata to CitusDB #56

Merged
merged 9 commits into from
Jan 20, 2015
Merged

Add function to sync metadata to CitusDB #56

merged 9 commits into from
Jan 20, 2015

Commits on Jan 19, 2015

  1. New UDF to sync metadata from pg_shard to CitusDB 

    Performs an on-demand sync from pg_shard's metadata to that of Citus.
    @sumedhpathak @jasonmp85
    sumedhpathak authored and jasonmp85 committed Jan 19, 2015
    Configuration menu
    Copy the full SHA
    d676a71 View commit details
    Browse the repository at this point in the history

  2. Reimplemented sync function in SQL 

    Now the only C function remaining returns the Var representation of the
partition column.
    @sumedhpathak @jasonmp85
    sumedhpathak authored and jasonmp85 committed Jan 19, 2015
    Configuration menu
    Copy the full SHA
    7e53bfd View commit details
    Browse the repository at this point in the history

  3. Reimplemented in PL/pgSQL instead of standard SQL 

    Also converted the C function to use an Oid, thus allowing us to keep ResolveRelationId unchanged.
    @sumedhpathak @jasonmp85
    sumedhpathak authored and jasonmp85 committed Jan 19, 2015
    Configuration menu
    Copy the full SHA
    75f2332 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2015

  1. Build Citus sync function as part of extension 

    Add object file to targets.
    @jasonmp85
    jasonmp85 committed Jan 20, 2015
    Configuration menu
    Copy the full SHA
    3ffa0b2 View commit details
    Browse the repository at this point in the history

  2. Change partition column function to ERROR on NULL 

    We won't call it this way, but just in case.
    @jasonmp85
    jasonmp85 committed Jan 20, 2015
    Configuration menu
    Copy the full SHA
    64569ea View commit details
    Browse the repository at this point in the history

  3. Clean up PL/pgSQL formatting, add COMMENTs 

    We use tabs, so switched to those. Also added NOT NULL and CONSTANT
modifiers to make variable declaration more explicit. Finally, added
function comments, which will display when users ask for descriptions
of functions.
    @jasonmp85
    jasonmp85 committed Jan 20, 2015
    Configuration menu
    Copy the full SHA
    80c9034 View commit details
    Browse the repository at this point in the history

  4. Add unit tests for sync functionality 

    Tests nodeToString internal UDF as well as the user-facing sync UDF.
    @jasonmp85
    jasonmp85 committed Jan 20, 2015
    Configuration menu
    Copy the full SHA
    6c57c8f View commit details
    Browse the repository at this point in the history

  5. Add comment to nodeToString C UDF 

    Forgot this one.
    @jasonmp85
    jasonmp85 committed Jan 20, 2015
    Configuration menu
    Copy the full SHA
    f013b29 View commit details
    Browse the repository at this point in the history

  6. Clean up includes 

    Feedback from IWYU.
    @jasonmp85
    jasonmp85 committed Jan 20, 2015
    Configuration menu
    Copy the full SHA
    0c0c3d3 View commit details
    Browse the repository at this point in the history