Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SIP-010 support #53

Closed
whoabuddy opened this issue May 28, 2021 · 2 comments · Fixed by #54, #56 or #61
Closed

Update SIP-010 support #53

whoabuddy opened this issue May 28, 2021 · 2 comments · Fixed by #54, #56 or #61

Comments

@whoabuddy
Copy link

Following the example of wrapped-nothing-v6 and the SIP-010 standard, a few more updates need to be made:

  • convert all but transfer function to define-read-only
  • update get-total-supply to use ft-get-balance for the FT
  • create new read-only function to return contract STX balance
@314159265359879
Copy link

I think this is not going the right way because there was a mistake deploying the SIP-010 standard trait.

It should be with 'get-'

Aulneau redeployed:

@friedger @hstove so the deployed trait is wrong and we need to deploy a new one with get- prefixes?

Yes, I have deployed them both:
mainnet: https://explorer.stacks.co/txid/0x1508a980ed063e85a38728fe5caad0815e2f4ece0a1d77111185cc8c39b4b0ad?chain=mainnet
testnet: https://explorer.stacks.co/txid/0x9e57a976d429181a93ae6487c607333ca9a30789e7328294521ee05c937ac3ad?chain=testnet

Originally posted by @aulneau in stacksgov/sips#5 (comment)

@whoabuddy
Copy link
Author

whoabuddy commented May 29, 2021

Reopened as get-balance-of is now get-balance per stacksgov/sips#5 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants