LoD metadata info for 2nd level objects

[balazsdukai]

The cityfeaturemetadata and the presentlods don't have the correct counts with 2nd level object, such as BuildingPart.

Reproduce with multi-lod 3D BAG data:

cjio 3dbag_v210908_fd2cee53_5786.json subset --id "NL.IMBAG.Pand.0518100000285075-0" --id NL.IMBAG.Pand.0518100000285075 save --indent one.json

Then one.json contains:

"cityfeatureMetadata": {
	"Building": {
		"uniqueFeatureCount": 1,
		"aggregateFeatureCount": 1,
		"presentLoDs": {
			"0": 1
		},
		"BuildingParts": 1
	}
},
"presentLoDs": {
	"0": 1
},

This shows that there is only LoD0 in the file. However, the file still had LoD0, 1.2, 1.3, 2.2 for the Building and its BuildingPart.

[LaurensJN]

I encountered a similar problem that when city_model.update_metadata() is invoked, only LoD0 is added to the PresentLoDs. I think the root of the problem is in the following lines, where all Parts are deleted from the c_o_p list:

cjio/cjio/metadata.py

Line 99 in d9b4636

c_o_c = [c_o_p.pop(c_o_p.index(x)) for x in c_o_p[:] if any(child in x for child in children)]

Following, only the parent IDs are checked for LoDs, while the LoDs from children are never added to the parents' LoDs:

cjio/cjio/metadata.py

Lines 114 to 126 in d9b4636

	for c_o in CityObjects:
	cm_type = CityObjects[c_o]["type"]
	if cm_type == "CityObjectGroup":
	CityObjects_md[cm_type]["uniqueFeatureCount"] += 1
	LoD_func()
	elif any(child in cm_type for child in children):
	CityObjects_md[parent(cm_type)][cm_type+"s"] += 1
	else:
	CityObjects_md[cm_type]["uniqueFeatureCount"] += 1
	CityObjects_md[cm_type]["aggregateFeatureCount"] += len(CityObjects[c_o]["geometry"])
	LoD_func()
	if cm_type == "TINRelief":
	CityObjects_md[cm_type]["triangleCount"] += sum([len(b) for g in CityObjects[c_o]["geometry"] for b in g["boundaries"]])