Add some CSS to tables #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the "tables" extra feature (enabled by default) tables are created perfectly fine but no styling is added to the tables by default. While the tables can be styled/themed via theme/brand setups as they are, not everyone using this XBlock may have access to these settings. Add some CSS to match the tables to the current raw-HTML XBlock tables to create a better and more cohesive user experience.
|
@fghaas the fact the we currently add no styling to tables whatsoever appears to look like tables are "broken". |
|
This looks good to me but I have no bandwidth to test this right now so I'll trust your judgment. :) If you say this is good, I'll approve and merge. |
|
I've tested it locally and I believe it's good to merge, we can ask on the forum for user feedback also, I believe this will be helpful for them. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the "tables" extra feature (enabled by default) tables
are created perfectly fine but no styling is added to the tables
by default.
While the tables can be styled/themed via theme/brand setups as they are,
not everyone using this XBlock may have access to these settings.
Add some CSS to match the tables to the current raw-HTML XBlock tables
to create a better and more cohesive user experience.