Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test cases for primary functionality #20

Closed
lukasnagl opened this issue Jul 31, 2017 · 3 comments
Closed

test cases for primary functionality #20

lukasnagl opened this issue Jul 31, 2017 · 3 comments

Comments

@lukasnagl
Copy link

Is there a reason there are no test cases for this project yet? Especially since this project is a wallet, I would have expected to find some test cases to ensure its correct functionality, at least for /wallet/index.js. Not wanting to sound indignant, just asking for reasons.

@canesin
Copy link
Contributor

canesin commented Jul 31, 2017

@j4zz you are right and wrong, all your comments would be right if the file was not pulled from: https://github.com/CityOfZion/neon-js .. that has the testing in place ;)

@canesin canesin closed this as completed Jul 31, 2017
@lukasnagl
Copy link
Author

In that case, shouldn’t neon-js be packaged up and used here, instead of copying files? Sorry if I’m being obnoxious, just being inquisitive to understand the project’s choices.

@canesin
Copy link
Contributor

canesin commented Jul 31, 2017

Now you can open another issue: It should, is just that things are moving really fast and development was done in one place and moved to other.. if you want to PR I`m sure Ethan is ok with receiving your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants