You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there a reason there are no test cases for this project yet? Especially since this project is a wallet, I would have expected to find some test cases to ensure its correct functionality, at least for /wallet/index.js. Not wanting to sound indignant, just asking for reasons.
The text was updated successfully, but these errors were encountered:
@j4zz you are right and wrong, all your comments would be right if the file was not pulled from: https://github.com/CityOfZion/neon-js .. that has the testing in place ;)
In that case, shouldn’t neon-js be packaged up and used here, instead of copying files? Sorry if I’m being obnoxious, just being inquisitive to understand the project’s choices.
Now you can open another issue: It should, is just that things are moving really fast and development was done in one place and moved to other.. if you want to PR I`m sure Ethan is ok with receiving your help.
Is there a reason there are no test cases for this project yet? Especially since this project is a wallet, I would have expected to find some test cases to ensure its correct functionality, at least for
/wallet/index.js
. Not wanting to sound indignant, just asking for reasons.The text was updated successfully, but these errors were encountered: