Skip to content

Commit

Permalink
replace eslint-plugin-eslint-comments
Browse files Browse the repository at this point in the history
now using @eslint-community/eslint-plugin-eslint-comments
  • Loading branch information
dangowans committed May 24, 2024
1 parent 4310e36 commit 13a0f65
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 36 deletions.
6 changes: 2 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ In the project's `eslint.config.js` file.
```javascript
import eslintConfigCityssm from 'eslint-config-cityssm'

export default [
...eslintConfigCityssm
]
export default [...eslintConfigCityssm]
```

## Included Plugins
Expand All @@ -30,7 +28,7 @@ export default [

- [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint)
- [eslint-config-love](https://www.npmjs.com/package/eslint-config-love)
- [eslint-plugin-eslint-comments](https://www.npmjs.com/package/eslint-plugin-eslint-comments)
- [@eslint-community/eslint-plugin-eslint-comments](https://www.npmjs.com/package/@eslint-community/eslint-plugin-eslint-comments)
- [eslint-plugin-import](https://www.npmjs.com/package/eslint-plugin-import)
- [eslint-plugin-jsdoc](https://www.npmjs.com/package/eslint-plugin-jsdoc)
- [eslint-plugin-n](https://www.npmjs.com/package/eslint-plugin-n)
Expand Down
3 changes: 2 additions & 1 deletion eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import eslint from '@eslint/js';
import eslintPluginEslintComments from '@eslint-community/eslint-plugin-eslint-comments/configs';
import eslintConfigLove from 'eslint-config-love';
import eslintPluginJsdoc from 'eslint-plugin-jsdoc';
import eslintPluginNoSecrets from 'eslint-plugin-no-secrets';
Expand All @@ -10,7 +11,7 @@ import eslintPluginUnicorn from 'eslint-plugin-unicorn';
import tseslint from 'typescript-eslint';
export default tseslint.config(
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
eslint.configs.recommended, ...tseslint.configs.recommended, eslintPluginJsdoc.configs['flat/recommended-typescript'], eslintPluginRegexp.configs['flat/recommended'],
eslint.configs.recommended, ...tseslint.configs.recommended, eslintPluginEslintComments.recommended, eslintPluginJsdoc.configs['flat/recommended-typescript'], eslintPluginRegexp.configs['flat/recommended'],
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
eslintPluginSecurity.configs.recommended,
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
Expand Down
3 changes: 3 additions & 0 deletions eslint.config.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import eslint from '@eslint/js'
import eslintPluginEslintComments from '@eslint-community/eslint-plugin-eslint-comments/configs'
import eslintConfigLove from 'eslint-config-love'
import eslintPluginJsdoc from 'eslint-plugin-jsdoc'
import eslintPluginNoSecrets from 'eslint-plugin-no-secrets'
Expand All @@ -14,6 +15,8 @@ export default tseslint.config(
eslint.configs.recommended,

...tseslint.configs.recommended,

eslintPluginEslintComments.recommended,
eslintPluginJsdoc.configs['flat/recommended-typescript'],
eslintPluginRegexp.configs['flat/recommended'],

Expand Down
47 changes: 18 additions & 29 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "eslint-config-cityssm",
"type": "module",
"description": "ESLint rules used in the City of Sault Ste. Marie's TypeScript projects.",
"version": "3.0.4",
"version": "3.1.0",
"main": "eslint.config.js",
"exports": {
".": "./eslint.config.js",
Expand Down Expand Up @@ -41,10 +41,10 @@
"author": "The Corporation of the City of Sault Ste. Marie",
"license": "Unlicense",
"dependencies": {
"@eslint-community/eslint-plugin-eslint-comments": "^4.3.0",
"@eslint/js": "^9.3.0",
"eslint": "^8.57.0",
"eslint-config-love": "^48.0.0",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-jsdoc": "^48.2.6",
"eslint-plugin-n": "^17.7.0",
Expand Down

0 comments on commit 13a0f65

Please sign in to comment.