raise and handle exception on temporary mail failure #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhl
requested changes
Jan 5, 2017
| @@ -152,7 +152,9 @@ def instanciate_answer(self, lines): | |||
| msg = email.message_from_string(msgtxt) | |||
| temporary, permanent = all_failures(msg) | |||
|
|
|||
| if temporary or permanent: | |||
| if temporary: | |||
There was a problem hiding this comment.
I'm not sure if in practice this happens with Exim, but flufl might return both email addresses with temporary failures and permanent failures, and if there are any in permanent it should still register a bounce. So maybe this condition should be if temporary and not permanent. (Or switch the cases round so it's if permanent ... elif temporary ... else ... end.)
mhl
approved these changes
Jan 5, 2017
struan
force-pushed
the
delayed-delivery-warnings
branch
from
bf90034
to
ff48605
Compare
If we get a temporary failure message then ignore it as we only need to do something if the failure is permanent.
struan
force-pushed
the
delayed-delivery-warnings
branch
from
ff48605
to
b2e64e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we get a temporary failure message then ignore it as we only need to
do something if the failure is permanent.