Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repoll when admin re-adds a pre-existing PopIt #826

Conversation

lfalvarez
Copy link
Member

When an admin tries to re-add a PopIt that is already linked, don't just show an error message, but instead repoll. Per discussion at #812 (comment)

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 32bd876 on ciudadanointeligente:issues/724b into ddff90f on ciudadanointeligente:issues/724-adding-a-source-should-let-you-know-if-has-already-been-linked.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 98.62% when pulling 32bd876 on issues/724b into ddff90f on issues/724-adding-a-source-should-let-you-know-if-has-already-been-linked.

Was: `You already have this popit instance relate. But we are updating the database anyway, to pull in any new contacts`.
Now: `You have already added this PopIt. But we will fetch the data from it again now.`

(I still don't think it's great, but there's an entire textual overhaul scheduled from Myf on Tuesday...)
@tmtmtmtm tmtmtmtm changed the title We know that you really didn't want to relate another popit to our write... Repoll when admin re-adds a pre-existing PopIt Apr 10, 2015
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling df3e84b on ciudadanointeligente:issues/724b into ddff90f on ciudadanointeligente:issues/724-adding-a-source-should-let-you-know-if-has-already-been-linked.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 98.62% when pulling df3e84b on issues/724b into ddff90f on issues/724-adding-a-source-should-let-you-know-if-has-already-been-linked.

tmtmtmtm added a commit that referenced this pull request Apr 10, 2015
Repoll when admin re-adds a pre-existing PopIt
@tmtmtmtm tmtmtmtm merged commit 8270586 into issues/724-adding-a-source-should-let-you-know-if-has-already-been-linked Apr 10, 2015
@duncanparkes duncanparkes deleted the issues/724b branch April 15, 2015 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants