Skip to content

Commit

Permalink
ctp2 code base as submodule, to avoid stale cache, idea from:
Browse files Browse the repository at this point in the history 
    https://ryanfb.github.io/etc/2015/07/29/git_strategies_for_docker.html#git-submodules-inside-dockerfile-repository
  • Loading branch information
@LynxAbraxas
LynxAbraxas committed Oct 8, 2018
0 parents commit 3a4a300
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "ctp2"]
path = ctp2
url = https://github.com/LynxAbraxas/ctp2_git-svn
1 change: 1 addition & 0 deletions ctp2
Submodule ctp2 added at ef644f

3 comments on commit 3a4a300

@DEVoytas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few things I do not quite understand in this commit. Maybe you can help me with that.

  • Why adding user-specific repo url to the "official" one?
  • Why do we need submodule at all? I probably misunderstand something, but after reading article linked in commit message I think we may be mixing two solution here. My understanding is that "Git submodules inside Dockerfile repository" solution is for project where Dockerfile is a separate project and one uses the code from another git repo to build inside docker container. In our case I think "Dockerfile inside git repository" solution applies, so there should be no issue with caching since you always build the code that is currently checked-out together with Dockerfile. You just do COPY ./ /src/dir/in/docker in the Dockerfile and current code gets copied there. Again, I am likely missing something here.

One more, minor thing: I think commit message could be little bit better :)
Especially if you look at the output of the shortlog for this PR (git shortlog 4609b56ab52c^2) it's little bit confusing (at least to me). I am big proponent of writing good commit messages and I always take opportunity to encourage people to follow this guidelines: https://chris.beams.io/posts/git-commit/ , or if that's too much to read, at least have a look here: https://github.com/erlang/otp/wiki/writing-good-commit-messages :)

@DEVoytas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LynxAbraxas , any chance you could response to my comments above?

@LynxAbraxas
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comments, e.g. #13 (comment) and 09c0e4f#commitcomment-31176356.

Please sign in to comment.