Debug piracy issue

[LynxAbraxas]

This PR solves the issue of #75, i.e. that the player does not get a colored square in the piracy column of the trade manager, nor the diplomatic option to ask for stopping piracy (#116) and is the base for PRs like #125 and #126.

[LynxAbraxas]

@MartinGuehmann what would you suggest to do with StopPirating in AutoAddOrders

civctp2/ctp2_code/gs/gameobj/ArmyData.cpp

Line 6057 in 0668dd1

StopPirating();

and AutoAddOrdersWrongTurn

civctp2/ctp2_code/gs/gameobj/ArmyData.cpp

Line 6095 in 0668dd1

StopPirating();

, same code snippet as well? Do you know when those are called?

[LynxAbraxas]

Wonderful! Works as expected and solves #75 and #116.
@MartinGuehmann Can go in from my side.

[MartinGuehmann]

, same code snippet as well? Do you know when those are called?

As you have already figured out: Yes. And then we wait for Travis.

[LynxAbraxas]

And then we wait for Travis.

Of corse (it had finished with the old ones but I just noticed I still had the debug fprintf in).
I'll start rebasing the other PRs on to this to sort things out a bit.

[MartinGuehmann]

Then this can go in.

[LynxAbraxas]

Great! This bug really bugged me. Many thanks @MartinGuehmann for helping to solve this.
It seems that it also has an interesting effect on the AI players. I guess that the AI players only got to know the pirating from the human player and not from the other AIs because of this bug. This might increase diplomatic interaction between the AI players.
I also observed that the pirating animation of AI units now only happens once (while it used to happen every turn, see e.g. the test game I uploaded) because the pirating order stays over turns as long as no action is taken that "turns it off". Perhaps this even stops the AI from trying to use transporters for pirating (have to observe this for longer).

@MartinGuehmann Would you say that this bug already was in the original version of cpt2 or was it introduced when pimping up the AI, making special use of AddOrder then?
Do you know when AutoAddOrders and AutoAddOrdersWrongTurn are used?