message for pirating civ about the gold captured #71
Conversation
|
In CTP1, we had two kinds of messages, one that said who the bastards were and one without that information. That should depend whether the bastards were visible on the map. But I think currently, this information is also available in the Diplomanager. So that it doesn't help to hide this and we can include as it is. |
|
The messages from CTP1 that I think your refer to seem to randomly give away who it was in the message to the player suffering the pirating. |
|
OK, I see could you still add the message to info_str.txt from the other languages, no translation is needed, except for the German file. The translation is:
|
LynxAbraxas
force-pushed
the
piratGoldMessage
branch
from
c6a0039
to
2fe17dc
Compare
|
The English info_str.txt now contains the message, twice. |
find -name info_str.txt | xargs sed -i '/^TRADE_PIRATED/aTRADE_PIRATE_GOLD "{gold[0].value} gold was pirated on the trade route from {city[0].name} to {city[1].name} owned by {player[0].civ_name_plural}."'
LynxAbraxas
force-pushed
the
piratGoldMessage
branch
from
2fe17dc
to
5e3285e
Compare
|
Ah, yes, many thanks for noticing that mistake, it's always good to have a review. |
I see. From my side it is OK, and I think it has been reviewed enough. So, when Travis is done it can go in. I don't expect any other people to comment on it. |
|
Thanks for merging. History looks exactly as expected and the commit preserveds its SHA. |
This PR introduces a game message to tell the pirating civilization what amount of gold was pirated from with trade route. This is in relation to #49.
Pirating with ctp2 style works in the way that a unit is placed on a trade route, ordered to pirate and then left there for the following turns. Gold will only be assigned at the beginning of each new turn if the unit stays there.