Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Smarty4 folder #380

Merged
merged 1 commit into from Feb 6, 2024
Merged

Add Smarty4 folder #380

merged 1 commit into from Feb 6, 2024

Conversation

eileenmcnaughton
Copy link
Contributor

I tried out smarty4& it looks like it's a small step from Smarty3 to Smarty4 but a bit trickier to Smarty5 until we get rid of Smarty2

I think it makes sense to add Smarty4 to our vendor dir to try out in the same way as Smarty3 & when we hard switch my recent testing suggests 4 rather than 3 makes sense

Copy link

civibot bot commented Jan 27, 2024

(Standard links)

@civibot civibot bot added the master label Jan 27, 2024
@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw
Copy link
Member

colemanw commented Feb 6, 2024

Why are we doing this in civicrm-packages instead of civicrm-core/composer.json?

@demeritcowboy
Copy link
Contributor

Probably because then the autoloader will pick it up even if you haven't enabled smarty 4.

@colemanw
Copy link
Member

colemanw commented Feb 6, 2024

Ok

@colemanw colemanw merged commit 14082b1 into civicrm:master Feb 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants