Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Re-write content on updating system workflow message templates after CiviCRM upgrades #53

Merged
merged 2 commits into from Nov 17, 2017

Conversation

seancolsen
Copy link
Contributor

Before

  • Content on updating system message templates was somewhat duplicated between the User Guide and the Sysadmin Guide (as described in #13 )
  • The tutorial instructed users to perform a two-way merge, which cannot be done automatically and is sometimes difficult even when done manually.

After

  • Concepts covered in the User Guide are now covered here (in preparation for removing this content from the User Guide and linking to the Sysadmin Guide)
  • The tutorial instructs users to perform a three-way merge using a base file. In most situations, KDiff3 will be able to automatically merge the changes, so I think that the extra step of finding and using the base file is well worth the time here.

These changes should resolve #13 (pending a corresponding PR on the User Guide that I'll be creating soon)

Anyone want to review this? @michaelmcandrew @MegaphoneJon @seamuslee001 ?

Within your installed CiviCRM files, navigate to `CRM/Upgrade` and look through the `*.msg_template` folders. Make sure to examine all versions between your previously-installed version and your currently-installed version.

!!! tip "For example"
By looking in the `4.7.23.msg_template` folder, we can see that the "Contribution invoice receipt" template was changed in version 4.7.23. So, if you are upgrading from a version prior to 4.7.23 to a version after 4.7.23, then you'll need to note this template as one which has changed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanmadsen it should be noted that in general hopefully there should be a post upgrade message which mentions any template updates but may not be 100% always true ping @totten

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought about that too. I've seen those messages, but I wasn't sure whether it would be a good idea to rely on them for these instructions. They seem somewhat ephemeral to me. Like, if there could be a way to go back and view that message after you exit the upgrade screen then we could give those instructions to the user. But if we rely on them having already looked at that message and remembered its content then I think some people will be frustrated. Tim maybe you know of a way to bring up that message again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what would be really cool (and maybe this already is the case?) is if that post upgrade message would specifically call attention to templates which users have customized and CiviCRM has upgraded. I haven't taken the time to generate this message and see what it says, but if it does in fact get that specific, then it would be quite compelling to rely on it!

seancolsen added a commit to seancolsen/civicrm-user-guide that referenced this pull request Nov 10, 2017
* Remove (and link to) duplicate content that was moved to the
  Sysadmin Guide in
  civicrm/civicrm-sysadmin-guide#53
* Add a screenshot
* Clarify the dangers of making updates to these templates
@seancolsen
Copy link
Contributor Author

Corresponding User Guide PR: civicrm/civicrm-user-guide#237 Please merge that one when merging this one

@seancolsen
Copy link
Contributor Author

I'm gonna go ahead and merge this since it's been a week. I'm happy to adjust this later on if others have more thoughts.

@seancolsen seancolsen merged commit 20e978e into civicrm:master Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants