Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Clarify permissions for 'profile listings and forms' #355

Closed
wmortada opened this issue Sep 5, 2018 · 8 comments · Fixed by #437
Closed

Clarify permissions for 'profile listings and forms' #355

wmortada opened this issue Sep 5, 2018 · 8 comments · Fixed by #437

Comments

@wmortada
Copy link
Contributor

wmortada commented Sep 5, 2018

I found the section on 'Using the "Profile listings and forms" permission' a bit unclear. I think it could be made clearer.

I have spent some time trying to understand exactly what the 'profile listing and forms' permission does. I believe that it is basically just a shortcut for applying all four separate permissions relating to profiles:

  • profile create
  • profile view
  • profile edit
  • profile listings

Could someone please confirm if this is true? If so, I would suggest that we make this explicit in the documentation. If not, I think we need to explain what this permission is more clearly.

@homotechsual
Copy link
Contributor

Yes, you're correct that the permission is a shortcut for the 4 permissions listed.

See https://github.com/civicrm/civicrm-core/blob/08cf6bdfcfcbfa51ff972dc214f3aa82c606efc7/CRM/Core/Permission.php from line 317

@homotechsual
Copy link
Contributor

@wmortada
Copy link
Contributor Author

Many thanks for the confirmation and for making the change to the documentation.

@github-actions
Copy link

This issue has had no activity in 60 days and has been marked as stale, it will be closed in 10 days.

@wmortada
Copy link
Contributor Author

I think the documentation is much clearer than I remember it from two years ago, but I think it would be better if it was completely explicit on this point. Should we add a line that says something along the lines of:

profile_listing_and_forms = profile_view + profile_create + profile_edit + profile_listing

?

@homotechsual
Copy link
Contributor

That sounds good to me!

@homotechsual homotechsual linked a pull request Apr 17, 2020 that will close this issue
@homotechsual
Copy link
Contributor

Linked a PR.

@wmortada
Copy link
Contributor Author

Thanks @MikeyMJCO

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants