Multiple features added #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homotechsual
reviewed
Sep 8, 2020
| } | ||
| var link_number = title.slice(string_index+1,issue_number_index) | ||
| var ref_link = 'https://lab.civicrm.org/dev' + '/' + link_head + '/-/issues/' + link_number | ||
| ref_link = 'The issue assosciated with the Pull Request can be viewed on this link ' + ref_link |
There was a problem hiding this comment.
Suggested change
| ref_link = 'The issue assosciated with the Pull Request can be viewed on this link ' + ref_link | |
| ref_link = 'The issue associated with this Pull Request can be viewed at: ' + ref_link |
|
There are some things in this code that are somewhat reusable (like logging into GitBeaker) and could be extracted into a utility function to make this cleaner/more maintainable in the future. |
|
Deployed to prod. Thank you @kartik1000 @homotechsual (and apologies for the delay, I wasn't subscribed to this repo). |
|
Thank you @mlutfy fore reviewing and merging. Happy to finally have this in prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request inlcudes rest of the features added during the GSoC Project which includes:
Two env variables GitHub_URL and GitHub_Token will need to be added to connect to GitLab using GitBeaker.
If a separate pull request for each feature is required, I can open that as well. Most of the features added are simply based on combinations of GitHub and GitLab APIs with string hashing or using GitHub commands extension.
If any changes are needed do let me know, I will be happy to do so. More information regarding the issues can be found at https://civicrm.org/blog/kartik1000/probots-and-gitlab-github-integration-final-phase-completion