Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and Implement identifier that differentiate between active and inactive organizations #1076

Open
3 of 4 tasks
kevindphan opened this issue Nov 18, 2021 · 11 comments
Open
3 of 4 tasks
Labels
p-feature: Organizations Everything relating to Organizations page Priority: High High Priority issues are critical and have to be fixed with immediate effect role: front end size: 2pt Can be done in about 12 hours

Comments

@kevindphan
Copy link
Member

kevindphan commented Nov 18, 2021

Overview

Need to create identifiers to differentiate between inactive and active organizations and inactive and active repos.

Details

  • An identifier can be a tag/logo/icon

Action Items

  • Create an identifier to differentiate between inactive and active orgs
    • Overwrite inactive if there are active repos
    • See state logic in resources below
  • Create an identifier for inactive and active repos
  • See and make requested changes in comments
  • Update Projects page

Resources/Instructions

Resources for Front End

  • Identifier will appear on this page in the organization box and also on the individual repos that appear on the detail page
Examples of where icons should appear
  • Note: The different states should be based on information in the back-end
  • Desired States:
    image
    Individual Organization - No Projects in Additional Repos

Resources for UI/UX

  • Identifier will appear on this page in the organization box and also on the individual repos that appear on the detail page
    Screen Shot 2021-11-17 at 8 46 16 PM
Identifiers should be visible on this details page

image

States:

  • Active Org/Active Repo (Organization still part of parent and any active repos)
  • Inactive Org/Active Repo (Not part of parent org, active repos)
  • Active Org/Inactive Repos (Organization still part of parent, no active repos)
  • Inactive Org/ Inactive Repos (Not part of parent org and no active repos)
@kevindphan kevindphan added role: UI/UX p-feature: Organizations Everything relating to Organizations page size: missing labels Nov 18, 2021
@kevindphan kevindphan added this to the 7 - MVP Website Launch milestone Nov 18, 2021
@kevindphan kevindphan added this to New Issue Approval in Project Management via automation Nov 18, 2021
@ExperimentsInHonesty
Copy link
Member

@ladissi or @kevindphan asked

Inactive/active org identifier
need to determine if launch critical

Answer: yes. I discussed this with the Brigade Project Index (CfA cross brigade group) Stakeholders and reviewed this with them, it is important to all.

@kevindphan kevindphan added this to Prioritized Backlog in Project Management Jan 16, 2022
@ExperimentsInHonesty ExperimentsInHonesty added size: 2pt Can be done in about 12 hours and removed size: missing labels Jan 16, 2022
@ExperimentsInHonesty ExperimentsInHonesty moved this from Prioritized Backlog to New Issue Approval (All new issues should be added to this column) in Project Management Jan 20, 2022
@ExperimentsInHonesty ExperimentsInHonesty moved this from New Issue Approval (All new issues should be added to this column) to Prioritized Backlog in Project Management Jan 20, 2022
@smsada smsada changed the title Create identifier that differentiate between active and nonactive organizations Create identifier that differentiate between active and inactive organizations Feb 9, 2022
@chalimar
Copy link
Member

Sharing Figma link to page to be updated

@smsada
Copy link
Member

smsada commented Mar 11, 2022

Updated Design with Identifiers
image

@smsada
Copy link
Member

smsada commented Mar 15, 2022

Requested changes:

  • Make Org and Repo indicators the same color
  • Have an indicator for inactive
  • In example, represent all potential states (active org active repo, active org inactive repo, inactive org active repo, inactive org inactive repo

Thought process on changes:

  • Color shouldn't be our main indicator between what is and isn't active as it becomes a disadvantage for color-blind individuals. A good litmus test would be to ask John Darragh (Slack ID: UFLDX9V19) to look at the colors

@joycekimdesigns
Copy link

joycekimdesigns commented Mar 29, 2022

Add to Individual Organization Page

Full Res. Image

Individual Organization - No Projects in Additional Repos

Screen Shot 2022-03-28 at 6 27 22 PM

@smsada
Copy link
Member

smsada commented Apr 1, 2022

Thanks for this @joycekimdesigns this looks good and I'll be sending it over to front-end development!

@smsada smsada added role: front end Priority: High High Priority issues are critical and have to be fixed with immediate effect and removed role: UI/UX labels Apr 1, 2022
@smsada smsada changed the title Create identifier that differentiate between active and inactive organizations Create and Implement identifier that differentiate between active and inactive organizations Apr 2, 2022
Project Management automation moved this from Prioritized Backlog to Done Apr 5, 2022
Project Management automation moved this from Done to In progress (actively working) Apr 5, 2022
@smsada smsada moved this from In progress (actively working) to Prioritized Backlog in Project Management Apr 8, 2022
@smsada
Copy link
Member

smsada commented Apr 10, 2022

Put this issue on hold until 2022/04/18 after states are defined


The plan is to do GitHub API calls once a month to see if a repos have been updated in [active range].

  • These calls would be spread out across the month as this can become a large number of API calls

  • We need to define what kind of information we need to store

  • Set definitions

    • Active - What is the timeline to be considered active
    • Inactive - What is the timeline to be considered Inactive
  • Discuss with developers what type of information is currently being called and stored for Organization Page (seen below) and what we would need to store the "active" and/or "inactive" state

    Example of "Last Updated" on Individual Organization page
Original Notes

We are doing GitHub API calls to see if changes to a Repo has been made in the Past Month. It could be done Once a month. This can be spread out across the month (this is a lot of API calls).

  • We need to store this data somewhere (likely new fields in Django)
  • Figure out what exactly we need to store
  • Definition:
    • What is an active
  • Have a larger conversation with the whole team about how we want to store the data (currently rendering in real-time when someone looks at an org page or search results page)

@smsada
Copy link
Member

smsada commented Apr 17, 2022

Defining States

  • Active: 6 months (for repos and orgs)
  • Active Org: at least one active repo

Resources

  • Github Definition: 60 Days before they stop running actions on repos that haven't had changes
    • This may be too quick
  • Include in FAQ: Is there anything else I should do to make my repo more useful to others?
  • New FAQ: What is your definition of inactive?
    • Github defines it as inactive in this community conversation after 60 days
    • We define it as 6 months

@smsada
Copy link
Member

smsada commented Apr 21, 2022

Remove 'Active Repo' status from the top of Individual organization pages

Thought Process

"Active Repo" is redundant if "Active Org" Status already exists. An Org is only active if a Repo is active so there is no state where active repo exists without active org

What needs removal

image

@smsada smsada mentioned this issue Apr 26, 2022
3 tasks
@smsada
Copy link
Member

smsada commented May 4, 2022

This issue is pending research into how to structure our Database in Treebeard to handle more edge cases and how to handle limiting the number of API calls we make to GitHub.

  • Vance is looking into creating a GitHub Application which will increase our rate limitations from 60/hr to 5000/hr

@smsada
Copy link
Member

smsada commented May 24, 2022

Making Dependency issues

  • Increase Rate Limitations
    • Consider developing Github Application
  • Update backend implementation of searching github to search based on our list instead of just on tags
    • Current implementation only scans github for organizations with our tag and doesn't return manually inputted entries from the back end if not already properly tagged on GitHub
  • Implement new database to track last updated information about an organization for state indicators
    • Bring Cynthia into the conversation to see how we might implement this
    • States need to be tracked for the purpose of the Civic Tech Organizations page as we only make API calls when a specific organization page is opened. If we have a database of knowing when the last updated state was, we can have a scheduler to update the list on a need basis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-feature: Organizations Everything relating to Organizations page Priority: High High Priority issues are critical and have to be fixed with immediate effect role: front end size: 2pt Can be done in about 12 hours
Projects
Project Management
  
Prioritized Backlog
Development

When branches are created from issues, their pull requests are automatically linked.

5 participants