[CIVIC-1449] Fixed Automated list filters not being hidden. #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudrasamey
added
the
State: Needs review
AlexSkrypnyk
requested changes
Nov 28, 2023
There was a problem hiding this comment.
@mudrasamey
Please see inline comments and update accordingly.
Also, please add Behat tests that demonstrate the case when:
- All filters selected
- Some filters selected
- None filters selected.
thank you
| $show_filters = !empty(array_filter(explode(', ', $settings['filters_exp']))); | ||
| if (!$show_filters) { | ||
| // Exposed filters. | ||
| $exposed_filter = explode(', ', $settings['filters_exp']); |
| if (!$show_filters) { | ||
| // Exposed filters. | ||
| $exposed_filter = explode(', ', $settings['filters_exp']); | ||
| $show_filters = !empty(array_filter($exposed_filter)); |
There was a problem hiding this comment.
please remove this and just use the count($exposed_filters)>0
| // Disable filters based on the component settings. | ||
| $view_filters = $view->display_handler->getOption('filters'); | ||
| foreach ($view_filters as $key => $filter) { | ||
| if (isset($filter['exposed']) && |
There was a problem hiding this comment.
replace
isset($filter['exposed']) &&
$filter['exposed'] &&
with
!empty($filter['exposed'])
| if ($show_filters) { | ||
| // Disable filters based on the component settings. | ||
| $view_filters = $view->display_handler->getOption('filters'); | ||
| foreach ($view_filters as $key => $filter) { |
There was a problem hiding this comment.
replace $key with $filter_identifier
AlexSkrypnyk
added
State: Requires more work
mudrasamey
force-pushed
the
feature/CIVIC-1449
branch
from
583449a
to
407cafc
Compare
|
@AlexSkrypnyk i have made the changes as per your suggestion. I have also added supporting behat test |
AlexSkrypnyk
changed the title
|
@mudrasamey Could you please fix the code to make the CI pass. Thank you |
AlexSkrypnyk
approved these changes
Dec 6, 2023
AlexSkrypnyk
added
State: Ready to be merged
AlexSkrypnyk
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://salsadigital.atlassian.net/browse/CIVIC-1449
Checklist before requesting a review
[CS-123] Verb in past tense with dot at the end.Changedsection about WHY something was done if this was not a normal implementationchanges, and they passed
Changed
Screenshots