Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3414203 by joshua1234511: Eslint fails in Starterkit "lint" script if there are no JS files in components. #1205

Merged
merged 1 commit into from Jan 22, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Jan 22, 2024

https://www.drupal.org/project/civictheme/issues/3414203

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [CS-123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Added ESLint flag --no-error-on-unmatched-pattern to civictheme_starter_kit/package.json to suppress the message.

Screenshots

Screenshot 2024-01-22 at 2 27 55 PM

@joshua-salsadigital joshua-salsadigital self-assigned this Jan 22, 2024
@joshua-salsadigital joshua-salsadigital added the State: Needs review Pull requests needs a review from assigned developers label Jan 22, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title [3414203] Fixed Eslint fails in Starterkit "lint" script if there are no JS files in components. Issue #3414203 by joshua1234511: Eslint fails in Starterkit "lint" script if there are no JS files in components. Jan 22, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit 3d2975a into develop Jan 22, 2024
12 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/3414203-eslint-fail-fix-subtheme branch January 22, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Needs review Pull requests needs a review from assigned developers
Projects
None yet
2 participants