Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3415747 by joshua1234511: Search for Component title / summary field is not working #1207

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Jan 23, 2024

https://www.drupal.org/project/civictheme/issues/3415747

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [CS-123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Enable this processor for components fields.

Screenshots

![FireShot Capture 003 - Test search issue - CivicTheme Source - defaultdev civictheme io](https://github.com/civictheme/monorepo-drup
Screenshot 2024-01-23 at 11 49 42 PM
al/assets/83997348/570ab839-72e4-41b2-8176-ebc0f6391886)

Screenshot 2024-01-24 at 12 37 59 PM

@joshua-salsadigital joshua-salsadigital self-assigned this Jan 23, 2024
@joshua-salsadigital joshua-salsadigital added the State: Needs review Pull requests needs a review from assigned developers label Jan 23, 2024
Copy link
Collaborator

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshua-salsadigital
Thank you for providing the fix.
In order to test this, we need to have the current search test to be updated to include the manual list component. Could you please update search.feature test.

@AlexSkrypnyk AlexSkrypnyk added State: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request and removed State: Needs review Pull requests needs a review from assigned developers labels Jan 23, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title [3415747] Added fix for search component title / summary field not working. Issue #3415747 by joshua1234511: Search for Component title / summary field is not working Jan 23, 2024
@joshua-salsadigital joshua-salsadigital added State: Needs review Pull requests needs a review from assigned developers and removed State: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request labels Jan 24, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit 99edd9e into develop Jan 26, 2024
12 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/3415747-search-processors branch January 26, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Needs review Pull requests needs a review from assigned developers
Projects
None yet
2 participants