Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3422805 by joshua1234511 Updated conditional check for navigation to support updated Navigation component in UIKit. #1234

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Mar 15, 2024

civictheme/uikit#113

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [CS-123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Added conditional check (as per description above) to enforce inline if none is selected in block--menu-block--civictheme-primary-navigation.html.twig and block--menu-block--civictheme-secondary-navigation.html.twig

Screenshots

@joshua-salsadigital joshua-salsadigital self-assigned this Mar 15, 2024
@joshua-salsadigital
Copy link
Collaborator Author

Pending: Update to the latest commit of UIKit

@joshua-salsadigital joshua-salsadigital added the State: Needs review Pull requests needs a review from assigned developers label Mar 15, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title [96] Updated conditional check for navigation. Issue #3422805 by joshua1234511 Updated conditional check for navigation to support updated Navigation component in UIKit. Mar 18, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit b1ce617 into develop Mar 18, 2024
2 of 6 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/96-footer-regression-fix branch March 18, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Needs review Pull requests needs a review from assigned developers
Projects
None yet
2 participants