Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select does not look as per designs #150

Closed
AlexSkrypnyk opened this issue May 29, 2024 · 4 comments · Fixed by #186 or #212
Closed

Select does not look as per designs #150

AlexSkrypnyk opened this issue May 29, 2024 · 4 comments · Fixed by #186 or #212
Assignees
Labels
State: In progress The issue is being worked on Type: Defect Issue is a defect
Milestone

Comments

@AlexSkrypnyk
Copy link
Contributor

Summary

Select does not look as per designs

Steps to reproduce

@joshua-salsadigital

Our current select does not look like the designs.

Cursor_and_CivicTheme__Design_System_v1_8_0__WIP_

Observed outcome

Expected outcome

@AlexSkrypnyk AlexSkrypnyk added the Type: Defect Issue is a defect label May 29, 2024
@AlexSkrypnyk AlexSkrypnyk added this to the 1.8 milestone May 29, 2024
@AlexSkrypnyk AlexSkrypnyk added the State: Confirmed The issue was triaged and confirmed for development label May 31, 2024
@AlexSkrypnyk AlexSkrypnyk added State: In progress The issue is being worked on and removed State: Confirmed The issue was triaged and confirmed for development labels Jun 3, 2024
AlexSkrypnyk added a commit that referenced this issue Jun 5, 2024
@sonamchaturvedi28
Copy link
Collaborator

Test Env: DEV
Test Status: FAIL
Test Result:

  • Below are the issues :
# Theme State Expected ActuaI
1 Dark theme Default state : Background colour is incorrect --ct-color-dark-background-dark --ct-color-dark-background-light
2 Dark theme Hover state : Background and border colours are incorrect Background colour: --ct-color-dark-background-dark Border colour: --ct-color-dark-interaction-hover-background Background colour: --ct-color-dark-background-light Border colour: --ct-color-dark-border-light
3 Dark theme Focus/ Invalid / Disabled states : Background colour is incorrect --ct-color-dark-background --ct-color-dark-background-light
4 Dark theme Selected state : Background colour is not as per Figma. Even when Background colour is updated as per Figma there seems to be contrast issue, selected option is not easily visible --ct-color-dark-background --ct-color-dark-background-light

Issue#1
image
Issue#2
image
Issue#4
image

@AlexSkrypnyk
Copy link
Contributor Author

@sonamchaturvedi28
An update was made. Could you please re-test. thanks

@sonamchaturvedi28
Copy link
Collaborator

sonamchaturvedi28 commented Jun 13, 2024

Test Env: DEV
Test Status: FAIL
Test Result:

Below are the issues :

# Issue Status
1 Dark theme Default state : Background colour is incorrect PASS
2 Dark theme Hover state : Background and border colours are incorrect PASS
3 Dark theme Focus/ Invalid / Disabled states : Background colour is incorrect FAIL - Font colour of selected option for Invalid state is incorrect
4 Dark theme Selected state : Background colour is not as per Figma. Even when Background colour is updated as per Figma there seems to be contrast issue, selected option is not easily visible PASS
5 Select style on mobile is not responsive FAIL

Issue#3
image

Issue#5
image

@sonamchaturvedi28
Copy link
Collaborator

Test Env: DEV
Test Status: PASS
Test Result:

  • Font colour of selected option for Invalid state is now correct.
  • Tested Select responsiveness by enabling the container to be resizable and it works fine.
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: In progress The issue is being worked on Type: Defect Issue is a defect
Projects
Status: Done
3 participants