Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field Group, Group filter, Pagination, List - Update to use Field #59

Closed
AlexSkrypnyk opened this issue Feb 22, 2023 · 2 comments
Closed

Field Group, Group filter, Pagination, List - Update to use Field #59

AlexSkrypnyk opened this issue Feb 22, 2023 · 2 comments
Assignees
@joshua-salsadigital
Labels
Type: Chore Issue is a related to a maintenance
Milestone
1.8

Comments

@AlexSkrypnyk
Copy link
Contributor

AlexSkrypnyk commented Feb 22, 2023 •
edited
Loading

See epic: #121

SD

  1. Update Group, Group filter, Pagination, List components to use the new Field component.
  2. Update component to use new helpers instead of using its own and decommission existing helpers.
@AlexSkrypnyk AlexSkrypnyk transferred this issue from civictheme/monorepo-drupal Jan 18, 2024
@AlexSkrypnyk AlexSkrypnyk reopened this Jan 18, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title [FEATURE] Component - Field Group - Storybook [FEATURE] Component - Field Group - UIKIt Jan 18, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title [FEATURE] Component - Field Group - UIKIt [FEATURE] Component - Field Group - UIKit Jan 18, 2024
@civictheme civictheme deleted a comment from fionamorrison23 Jan 18, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title [FEATURE] Component - Field Group - UIKit Component - Field Group - UIKit Jan 19, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title Component - Field Group - UIKit Component - Field Group Jan 19, 2024
@AlexSkrypnyk AlexSkrypnyk added the State: Needs triage An issue or PR has not been assessed and requires a triage label Jan 19, 2024
@AlexSkrypnyk AlexSkrypnyk mentioned this issue Mar 27, 2024
Closed
@AlexSkrypnyk AlexSkrypnyk changed the title Component - Field Group Field Group - Update to use Field Mar 27, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title Field Group - Update to use Field Field Group, Group filter, Pagination, List - Update to use Field Mar 27, 2024
@AlexSkrypnyk AlexSkrypnyk added Type: Chore Issue is a related to a maintenance State: Confirmed The issue was triaged and confirmed for development and removed Type: Feature Issue is a new feature request State: Needs triage An issue or PR has not been assessed and requires a triage labels Mar 28, 2024
@AlexSkrypnyk AlexSkrypnyk modified the milestones: 1.10, 1.8 Mar 28, 2024
@joshua-salsadigital joshua-salsadigital mentioned this issue Jun 6, 2024
Merged
7 tasks
@fionamorrison23 fionamorrison23 added PR: Needs review Pull request needs a review from assigned developers and removed State: Confirmed The issue was triaged and confirmed for development labels Jun 10, 2024
AlexSkrypnyk added a commit that referenced this issue Jun 13, 2024
@joshua-salsadigital @AlexSkrypnyk
[#59] Updated Field usage. Part 1 (#190)
e99d45a 
Co-authored-by: Joshua Fernandes <“joshua.1234511@yahoo.in”>
Co-authored-by: Alex Skrypnyk <alex@drevops.com>
@AlexSkrypnyk AlexSkrypnyk removed the PR: Needs review Pull request needs a review from assigned developers label Jun 13, 2024
@AlexSkrypnyk
Copy link
Contributor Author

Implemented

@sonamchaturvedi28
Copy link
Collaborator

Test Env: DEV
Test Status: PASS
Test Result:

Issues Status
Input component: Calendar and clock icons for dark theme are not visible
Type : Date, Month, Time, Week.		 This is fixed.
PASS
Field component - Horizontal Orientation - No description and message content : Then Field label is not correctly aligned with input types such as Textfield, Email, Color. New ticket created as Label on horizontal Field shrinks for small fields · Issue #277 · civictheme/uikit
Group-filter : we have description in the dropdown however no attribute to remove it. This is fixed, description does not render in dropdown.
PASS
Pagination :
Active is link and Ellipsis attributes are not working.
Pagination number is missing on mobile.		 New defect ticket Component - Pagination issues · Issue #280 · civictheme/uikit .

Screenshots:
Screenshot 2024-06-21 at 12 22 01 PM

Screenshot 2024-06-21 at 12 25 41 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshua-salsadigital joshua-salsadigital

Labels
Type: Chore Issue is a related to a maintenance
Projects
UI Kit
Status: Done
Milestone
1.8
Development

No branches or pull requests
4 participants
@AlexSkrypnyk @sonamchaturvedi28 @joshua-salsadigital @fionamorrison23