-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Quote component to support citation #97
Comments
@AlexSkrypnyk @joshua-salsadigital as we are decommissioning the actual quote component https://www.drupal.org/project/civictheme/issues/3415738 this work needs to be done on the Quote style in the CK Editor. |
@joshua-salsadigital this one is in 1.8, not 1.7. The only reason being we are decommissioning the qute component and instead using the CK Editor quote tool. The work you have done, where does it apply? |
@fionamorrison23 This is a part of change required for https://www.drupal.org/project/civictheme/issues/3415738 Quote style in the CK Editor. (Is this a new requirement) |
@sonamchaturvedi28 |
@fionamorrison23 |
Test link: https://civictheme-uikit.netlify.app
![]() |
Current implementation of the Quote component does not allow to have citation sitting inside of the
<blockquote>
tag.This is a problem for the cases when the tag needs to be native (used as a
<blockquote>
rather than a whole wrapping<div>
with inner elements) within other HTML content.Luckily, there is a
<cite>
tag that can be used within<blockquote>
:Solution direction
Quote
component to use the new structure and update SCSS.Note
This is a blocker for https://www.drupal.org/project/civictheme/issues/3415738
The text was updated successfully, but these errors were encountered: