Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Quote component to support citation #97

Closed
AlexSkrypnyk opened this issue Mar 7, 2024 · 6 comments · Fixed by #99
Closed

Refactor Quote component to support citation #97

AlexSkrypnyk opened this issue Mar 7, 2024 · 6 comments · Fixed by #99
Labels
State: Done The issue is complete and waiting for a release Type: Defect Issue is a defect
Milestone

Comments

@AlexSkrypnyk
Copy link
Contributor

AlexSkrypnyk commented Mar 7, 2024

Current implementation of the Quote component does not allow to have citation sitting inside of the <blockquote> tag.

<figure class="ct-quote ct-theme-light  ">
    <blockquote class="ct-quote__content">
      Quote content
    </blockquote>      
    <figcaption class="ct-quote__author">
        Quote author
    </figcaption>
</figure>

This is a problem for the cases when the tag needs to be native (used as a <blockquote> rather than a whole wrapping <div> with inner elements) within other HTML content.

Luckily, there is a <cite> tag that can be used within <blockquote>:

<blockquote class="ct-quote ct-theme-light">
  Quote content
  <cite>
  Quote author
  </cite>
</blockquote> 

Solution direction

  1. Refactor the Quote component to use the new structure and update SCSS.

Note

This is a blocker for https://www.drupal.org/project/civictheme/issues/3415738

@AlexSkrypnyk AlexSkrypnyk added Type: Defect Issue is a defect State: Confirmed The issue was triaged and confirmed for development State: Needs triage An issue or PR has not been assessed and requires a triage and removed State: Confirmed The issue was triaged and confirmed for development labels Mar 7, 2024
@fionamorrison23
Copy link
Collaborator

@AlexSkrypnyk @joshua-salsadigital as we are decommissioning the actual quote component https://www.drupal.org/project/civictheme/issues/3415738 this work needs to be done on the Quote style in the CK Editor.

@fionamorrison23
Copy link
Collaborator

@joshua-salsadigital this one is in 1.8, not 1.7. The only reason being we are decommissioning the qute component and instead using the CK Editor quote tool. The work you have done, where does it apply?

@joshua-salsadigital
Copy link
Collaborator

@fionamorrison23 This is a part of change required for https://www.drupal.org/project/civictheme/issues/3415738
which will handle the existing data.

Quote style in the CK Editor. (Is this a new requirement)

@fionamorrison23 fionamorrison23 modified the milestones: 1.8, 1.7 Mar 7, 2024
AlexSkrypnyk added a commit that referenced this issue Mar 11, 2024
Co-authored-by: Joshua Fernandes <“joshua.1234511@yahoo.in”>
Co-authored-by: Alex Skrypnyk <alex@drevops.com>
@AlexSkrypnyk AlexSkrypnyk reopened this Mar 11, 2024
@AlexSkrypnyk
Copy link
Contributor Author

@AlexSkrypnyk
Copy link
Contributor Author

@fionamorrison23
this work has been done and can be shipped in 1.7
The decommissioning of the Quote component depends on this ticket, but this ticket does not depends on that one.

@fionamorrison23 fionamorrison23 added PR: Ready for test Pull request is ready for manual testing and removed State: Needs triage An issue or PR has not been assessed and requires a triage labels Mar 12, 2024
@sonamchaturvedi28
Copy link
Collaborator

Test link: https://civictheme-uikit.netlify.app
Test Status: PASS
Test Result:

  • Quote component supports citation
  • There is a <cite> tag used within <blockquote>
image

@sonamchaturvedi28 sonamchaturvedi28 added PR: Ready to be merged Pull request is ready to be merged (assigned after testing is complete) and removed PR: Ready for test Pull request is ready for manual testing labels Mar 14, 2024
@fionamorrison23 fionamorrison23 added State: Done The issue is complete and waiting for a release and removed PR: Ready to be merged Pull request is ready to be merged (assigned after testing is complete) labels Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Done The issue is complete and waiting for a release Type: Defect Issue is a defect
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants