Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add button enable/disable logic when answering enumerator questions #7321

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

jeffpw-goog
Copy link
Contributor

@jeffpw-goog jeffpw-goog commented Apr 26, 2024

Description

When filling out an enumerator question in an application, the Add button is supposed to be disabled if any of the entries are blank. This only worked for entries that were created in the current page load. If entries were saved and then the page was reloaded, they would no longer participate in the enable/disable logic. This fixes that inconsistency so if an existing entry is blanked out the add button will be disabled.

Checklist

General

Read the full guidelines for PRs here

  • Added the correct label: < feature | enhancement | bug | under-development | dependencies | infrastructure | ignore-for-release | database >
  • Assigned to a specific person, civiform/developers, or a more specific round-robin list
  • Added an additional reviewer from outside your organization as FYI (if the primary reviewer is in the same organization as you)
  • Created unit and/or browser tests which fail without the change (if possible)
  • Performed manual testing (Chrome and Firefox if it includes front-end changes)

Instructions for manual testing

Steps to reproduce are in #7317.

Issue(s) this completes

Fixes #7317

@jeffpw-goog jeffpw-goog added the bug Something isn't working label Apr 26, 2024
@jeffpw-goog jeffpw-goog self-assigned this Apr 26, 2024
@jeffpw-goog jeffpw-goog marked this pull request as ready for review April 26, 2024 20:29
@jeffpw-goog jeffpw-goog marked this pull request as draft April 29, 2024 15:54
@jeffpw-goog jeffpw-goog force-pushed the jeffpw/enum-add branch 2 times, most recently from bc5f7e2 to 461539e Compare April 29, 2024 19:59
@jeffpw-goog jeffpw-goog marked this pull request as ready for review April 29, 2024 21:19
@jeffpw-goog jeffpw-goog merged commit aef607c into main Apr 30, 2024
19 checks passed
@jeffpw-goog jeffpw-goog deleted the jeffpw/enum-add branch April 30, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enumerator response add button enable/disable logic does not work for existing data
2 participants