Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove year, month, and day from predicate view dropdown #7418

Merged
merged 2 commits into from
May 6, 2024

Conversation

greg-hyde
Copy link
Contributor

@greg-hyde greg-hyde commented May 6, 2024

Description

In #6703 , we accidentally added the year, month, and day scalars to the dropdown where we configure eligibility questions. This PR removes that part of the change, since those paths are only used on the frontend and not for storage

Checklist

General

Read the full guidelines for PRs here

  • Added the correct label: < feature | enhancement | bug | under-development | dependencies | infrastructure | ignore-for-release | database >
  • Assigned to a specific person, civiform/developers, or a more specific round-robin list
  • Added an additional reviewer from outside your organization as FYI (if the primary reviewer is in the same organization as you)
  • Performed manual testing (Chrome and Firefox if it includes front-end changes)

User visible changes

  • Didn't use a message in applicant facing code that isn't translated yet (unless behind a flag)
  • Wrote browser tests using the validateAccessibility method
  • Tested on mobile view. See mobile device mode
  • Manually tested at 200% size
  • Manually evaluated tab order

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @greg-hyde and the rest of your teammates on Graphite Graphite

@greg-hyde greg-hyde added bug Something isn't working [Epic] North Star Applicant UI Related to UI changes to enable the North Star UX applicant experience labels May 6, 2024
@greg-hyde greg-hyde marked this pull request as ready for review May 6, 2024 18:10
@greg-hyde greg-hyde merged commit 0f01b5a into main May 6, 2024
20 checks passed
@greg-hyde greg-hyde deleted the greg-hyde/predicate-view branch May 6, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [Epic] North Star Applicant UI Related to UI changes to enable the North Star UX applicant experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants