play3 #7467
Draft
play3 #7467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't reloading the object for one. Second there is a difference in the instant precision in the assertion when hasmessage serializes the object. Just setting the id and not the whole object to be in the exception message string. We don't need to be logging the details anyway.
The string that was used in the regex is now formatted differently.
Running Prometheus metric sampler now has two samples which was breaking tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7467 +/- ##
============================================
+ Coverage 82.42% 83.15% +0.73%
- Complexity 3882 3889 +7
============================================
Files 469 484 +15
Lines 16526 18312 +1786
Branches 1133 1133
============================================
+ Hits 13621 15227 +1606
- Misses 2459 2640 +181
+ Partials 446 445 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some environment variables that have
Akkain their name. These will need to be changed, but will affect deployments. We can update them later. The name has no bearing on the upgrade.mfs.name == "applicant_id_in_profile"
and includes "applicant_id_in_profile_total" and "applicant_id_in_profile_created"