-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect deprecation warning when calling civis_file_to_table
#360
Comments
This warning has been popping up for me too. My suggestion is that you move |
I'd be inclined to just remove the deprecation warning and leave It seems not uncommon for python libraries to have arguments be singular when a single value or list could be provided (e.g., Also, if we're concerned about The PR that I believe introduced this issue: #328 |
@mheilman , would you accept a PR which removed the deprecation warning and left the code unchanged? Or would you like to continue to move toward a |
Yeah, I think we should just remove the deprecation warning. I'd be happy to accept that PR (or let me know if you'd like me to make the PR). Thanks for reminding me about this. |
There was no way for users to avoid this deprecation warning when calling `civis.io.civis_file_to_table`, and it was also triggered by other functions which called `civis_file_to_table` (such as `dataframe_to_civis`). The original thought had been to replace the singular `file_id` parameter with a plural `file_ids` parameter in v2, but per discussion in civisanalytics#360, the singular will be acceptable.
There was no way for users to avoid this deprecation warning when calling `civis.io.civis_file_to_table`, and it was also triggered by other functions which called `civis_file_to_table` (such as `dataframe_to_civis`). The original thought had been to replace the singular `file_id` parameter with a plural `file_ids` parameter in v2, but per discussion in #360, the singular will be acceptable.
file_id
is deprecated only as a named parameter, but the@deprecate_param
decorator issues a warning whetherfile_id
is used as a named parameter or a positional parameter. This also causes invalid warnings when usingdataframe_to_civis
orcsv_to_civis
.civis-python/civis/io/_tables.py
Line 877 in 94da3a0
The text was updated successfully, but these errors were encountered: