handle deprecated endpoints #353
Conversation
|
@stephen-hoover Wanted to flag this for you, since you might have more context on the original decision here. @salilgupta1 , can you note in the description that this closes #345 ? |
| deprecated = operation.get('deprecated', False) | ||
| if 'deprecated' in summary.lower() or deprecated: | ||
| deprecation_warning = operation.get("x-deprecation-warning", None) | ||
| if 'deprecated' in summary.lower(): |
There was a problem hiding this comment.
I have to leave this in because there seem to be a handful of endpoints that use this paradigm. We can get rid of this once we remove those endpoints.
There was a problem hiding this comment.
Strange that we have endpoints which explicitly do not work but are marked as deprecated. This seems like a reasonable workaround in the meantime.
Thanks for the flag, but I don't recall being involved in any discussions around the initial implementation of this part of the code. |
salilgupta1
force-pushed
the
handle-deprecated-endpoints
branch
from
2ec6839
to
57fdb0b
Compare
| deprecated = operation.get('deprecated', False) | ||
| if 'deprecated' in summary.lower() or deprecated: | ||
| deprecation_warning = operation.get("x-deprecation-warning", None) | ||
| if 'deprecated' in summary.lower(): |
There was a problem hiding this comment.
Strange that we have endpoints which explicitly do not work but are marked as deprecated. This seems like a reasonable workaround in the meantime.
One thing to note:
deprecatedandwarningset, not one or the other.This PR will close #345.