Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PARO-685] DOC update language for CivisML version #358

Merged
merged 3 commits into from
Feb 6, 2020

Conversation

jacksonllee
Copy link
Contributor

@jacksonllee jacksonllee commented Feb 6, 2020

The documentation for the CivisML version implies that the major use of the civisml_version parameter (added in #341) is to use an older version of CivisML, which seems slightly misleading. I'm updating the docs to clarify that it's about pinning the version for production work as a more probable use case.

The parallel PR for civis-r is civisanalytics/civis-r#225

Copy link

@sahildshah1 sahildshah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacksonllee jacksonllee merged commit bc44bfd into master Feb 6, 2020
@jacksonllee jacksonllee deleted the paro-685-civisml-version-docs branch February 6, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants