Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden parameter on civis_file_to_table #364

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

aripollak
Copy link
Contributor

  • In commit 95b1d90, the hidden parameter stopped getting passed to the import POST, but it looks like that was accidental.

* In commit 95b1d90, the hidden parameter stopped getting passed to the
  import POST, but it looks like that was accidental.
Copy link
Contributor

@zacharydfriedlander zacharydfriedlander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this fix!

cc @elsander for viz

@aripollak aripollak merged commit ed62557 into master Feb 24, 2020
@aripollak aripollak deleted the civis-file-to-table-hidden branch February 24, 2020 16:19
aripollak pushed a commit that referenced this pull request Mar 2, 2020
aripollak pushed a commit that referenced this pull request Mar 2, 2020
@jacksonllee jacksonllee added the bug label Mar 3, 2020
@jacksonllee jacksonllee added this to the Next Version milestone Mar 3, 2020
aripollak added a commit that referenced this pull request Mar 5, 2020
* Fix style of other entries

Co-authored-by: Salil Gupta <salil.gupta323@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants