Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme and setup.py to appease twine #373

Merged
merged 3 commits into from
Mar 5, 2020
Merged

Fix readme and setup.py to appease twine #373

merged 3 commits into from
Mar 5, 2020

Conversation

jacksonllee
Copy link
Contributor

We were not able to build distributions with twine for a new release, because twine doesn't allow duplicate references in the reStructuredText-formated README (not sure why this didn't come up before for previous releases, but I don't think we're interested in digging into this now). Also fixed is the missing long_descritption_content_type kwarg in setup.py, which twine threw a warning for.

With this PR, locally I tested it by building the source distribution and checking with twine again. Everything looks good now:

$ twine check dist/civis-1.13.0.tar.gz 
Checking dist/civis-1.13.0.tar.gz: PASSED

Copy link
Contributor

@salilgupta1 salilgupta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacksonllee jacksonllee merged commit ab19a8a into civisanalytics:master Mar 5, 2020
@jacksonllee jacksonllee deleted the fix-readme-to-appease-twine branch March 5, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants