Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed/relaxed version specifications for click, jsonref, and jsonschema. #377

Merged

Conversation

mheilman
Copy link
Contributor

Fixes #376

@mheilman
Copy link
Contributor Author

To test this, I uninstalled click, ran pip install -e . to reinstall civis-python, and the latest version of click (7.1.1) was installed.

@jacksonllee
Copy link
Contributor

Should we add pip list as the last step in the build, around and after here? That way, the build can tell us what's in a clean-slate environment for this sort of issues/bugs.

Copy link

@stephen-hoover stephen-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thank you for including jsonref and jsonschema as well.

@mheilman
Copy link
Contributor Author

@jacksonllee, travis already shows the versions of packages that get installed, if you expand the logs a bit (e.g., Successfully installed cbor2-5.0.1 civis click-7.1.1 cloudpickle-1.3.0 importlib-metadata-1.5.0 jsonref-0.2 jsonschema-3.2.0 pubnub-4.5.0 pycryptodomex-3.9.7 pyrsistent-0.15.7 zipp-3.1.0 here). Does that satisfy your request for a pip list?

@jacksonllee
Copy link
Contributor

travis already shows the versions of packages that get installed, if you expand the logs a bit

Yeah I'm aware of that, though IMO it's not as nice as pip list or pip freeze as a final report. :-) Feel free to ignore my comment and merge this in.

@mheilman mheilman merged commit c5098c0 into civisanalytics:master Mar 18, 2020
@mheilman mheilman deleted the fix-dep-version-inequalities branch March 18, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirements incompatible with click v7.1
3 participants