-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APIC-273] Add Table Columns Parameter #379
[APIC-273] Add Table Columns Parameter #379
Conversation
Tagging @salilgupta1 since Team Sparkle owns the API clients now. |
Oh sorry, I forgot that switch happened. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good, but I want to double check a few cases before we move forward with an approval (pending approval as well from maintainers):
- import to a pre-existing table with non-drop mode and table columns not specified - this should work fine.
- import to pre-existing table with
existing_table_rows=drop
and table columns not specified - this should cause thePreprocessCsv
to detect columns. - import to pre-existing table with
existing_table_rows=drop
and table columns specified - this should cause thePreprocessCsv
not to detect columns. - import to non-existent table with table columns specified - this should also cause the
PreprocessCsv
not to detect columns.
We should also double check importing more than one file (with the same schema) with table) with civis_file_to_table
directly to make sure that is working as expected.
manual tests ran added to description of the PR |
I'm cool with this. I defer to @zacharydfriedlander for final approval |
also, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sorry figured we should update the changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JIRA Ticket:
APIC-273
Summary:
Adding the table_columns parameter to io methods.
Testing:
Manual Tests
civis_file_to_table
Job 70579238Notes:
Additional Info: