[APIC-300] bump minimum pubnub version #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the pubnub changelog, they fixed all the keyword clashes (for async and await) since the v4.1.2 released in Sept 2018. I don't fully understand all the reasons I ran into this issue, but it's quick change.
|
Would you mind also updating the line in the requirements.txt? |
|
One more spot to change: Line 7 in 3fdceb9 |
jacksonllee
approved these changes
Jun 25, 2020
|
@jacksonllee, do you think we should only allow squash and merge? It's possible to disable the other 2 options |
Yeah, allowing "squash and merge" only for this repo seems reasonable. If we did come across edge cases where we'd need the other merge options, we could always re-enable them... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the pubnub changelog, they fixed all the keyword clashes (for async and await) since the v4.1.2 released in Sept 2018.
I don't fully understand all the reasons I ran into this issue (why an older pubnub version was pulled in on my fresh install), but it's quick change.