Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIC-76] include services and other missing resources in sphinx docs #406

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

mheilman
Copy link
Contributor

@mheilman mheilman commented Sep 9, 2020

This adds some missing API resources to the list of resources that the sphinx doc generation code uses to create https://civis-python.readthedocs.io/en/stable/api_resources.html. Using the list to filter the resources is a way to avoid including, e.g., "admin" endpoints that users aren't going to be interested in. Maybe we should eventually just include all the resources in the doc, but I didn't want to make that larger change at the moment.

… `json_values`, `services`, and `storage_hosts` so that they show up in the sphinx docs
Copy link
Contributor

@salilgupta1 salilgupta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mheilman mheilman merged commit 3ef5fe5 into civisanalytics:master Sep 9, 2020
@mheilman mheilman deleted the include_resources_in_docs branch September 9, 2020 19:47
byndcivilization added a commit that referenced this pull request Sep 10, 2020
…city

* master:
  [APIC-314] Refactored File Cleaning Logic (#405)
  [APIC-307] fix a workflows usage example in docs/source/client.rst (#409)
  add some missing PR numbers to the changelog (#408)
  Update the API spec at `civis/tests/civis_api_spec.json` so that new endpoints are included (e.g., `/exports/files/csv`) (#407)
  Updated list of base API resources to include `aliases`, `git_repos`, `json_values`, `services`, and `storage_hosts` so that they show up in the sphinx docs (#406)
  [APIC-284] remove python 3.5 support since it is reaching EOL (#404)
  [APIC-305] Require sql_type for every column when table_columns is provided (CHANGELOG) (#403)
  [APIC-313] retain specific sql types in civis_file_to_table (#402)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants