Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EmptyResultError to read_civis docs #412

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Add EmptyResultError to read_civis docs #412

merged 2 commits into from
Nov 30, 2020

Conversation

aripollak
Copy link
Contributor

No description provided.

mheilman
mheilman requested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@mheilman mheilman left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a changelog entry?

(looks good otherwise)

mheilman
mheilman approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@mheilman mheilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@aripollak aripollak merged commit 89ba777 into master Nov 30, 2020
@aripollak aripollak deleted the emptyresulterror branch November 30, 2020 22:47
@jacksonlee-civis jacksonlee-civis added this to the v1.16.0 milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheilman mheilman mheilman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aripollak @mheilman @jacksonlee-civis