Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVP-22369] - bug fix retry on iterate #413

Merged
merged 7 commits into from
Oct 28, 2020

Conversation

byndcivilization
Copy link
Contributor

fixed retry bug

Copy link
Contributor

@mheilman mheilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding/revising a test so that the previous version would fail?

CHANGELOG.md Outdated Show resolved Hide resolved
@byndcivilization
Copy link
Contributor Author

@mheilman how does this look?

civis/tests/test_utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mheilman mheilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byndcivilization byndcivilization merged commit 446b54a into master Oct 28, 2020
@byndcivilization byndcivilization deleted the CIVP-22369-bug-fix-retry-on-iterate branch October 28, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants