[CIVP-24658] REF Remove PubNub #425
Conversation
| # Otherwise the job might complete after polling and before | ||
| # we subscribe, causing us to miss the notification. | ||
| with self._condition: | ||
| if hasattr(self.client, 'channels') and not self.subscribed: |
There was a problem hiding this comment.
All the PubNub code was triggered by this sort of "if there's the Channels endpoint and not yet subscribed, do the PubNub thing" logic. Since the Channels endpoint has been removed, code removal in this PR is practically about dropping all references to PubNub as well as related references of "subscribe", "listen", and "channels".
There was a problem hiding this comment.
Looks great! Thank you for tackling this and tracking down so much code.
I still see some references to pubnub/channels in cassettes and in MANIFEST.in. Are you able to remove those lines/files as well? Since you've removed the test code, I think you should be able to remove all the cassettes that are calling https://api.civisanalytics.com/channels.
|
@skomanduri Thanks for catching more PubNub/Channels remnants! I've just removed those as well and the CI builds have passed. This PR is ready for another review. |
…re (#426) * ENH add job and run IDs to CivisJobFailure * MAINT update changelog * ENH move #416 changes from ContainerFuture to CivisFuture * FIX adjust ContainerFuture and tests * ENH log retrieval works for CivisFuture more generally * RM _poll_and_set_api_result (should've been rm-ed at #425) * MAINT update changelog * TST make ModelFuture tests work with client.jobs.list_runs_logs * TST update mock client for ModelFuture tests * TST more clean-up for ModelFuture tests * FIX comment * ENH rewrite logic to add job/run ID in CivisJobFailure * TST refactor _create_poller_mock * TST poller call count for poll_on_creation True/False * ENH more natural log message order * ENH wait for delayed traceback in log * ENH clearer error message * ENH simplify error message a bit * TST revert unnecessary tweak
This PR removes all PubNub-related code, as we've stopped using PubNub for quite a while. There's no effect to the users of civis-python, because the code being removed has not been triggered since PubNub usage was dropped from Civis Platform.