Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIVIS-1609] FIX remove more assert statements #435

Merged
merged 3 commits into from
Nov 22, 2021
Merged

[CIVIS-1609] FIX remove more assert statements #435

merged 3 commits into from
Nov 22, 2021

Conversation

jacksonlee-civis
Copy link
Member

This PR is a follow-up of #430, where I missed the assert statements in _tables.py somehow.

gkcivis
gkcivis approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@gkcivis gkcivis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacksonlee-civis jacksonlee-civis merged commit 738353a into master Nov 22, 2021
@jacksonlee-civis jacksonlee-civis deleted the civis-1609-more-assert branch November 22, 2021 15:16
@jacksonlee-civis jacksonlee-civis added this to the v1.16.0 milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkcivis gkcivis gkcivis approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jacksonlee-civis @gkcivis